Improve logs by showing original and updated versions of modules

PrestaShop · Sep 4, 2024 · 43fe833 · 43fe833
1 parent 02f23b8
commit 43fe833
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/classes/UpgradeTools/Module/ModuleDownloader.php b/classes/UpgradeTools/Module/ModuleDownloader.php
@@ -100,7 +100,12 @@ private function attemptDownload(ModuleDownloaderContext $moduleDownloaderContex
         $this->assertDownloadedContentsIsValid($destinationPath);
         $moduleDownloaderContext->setPathToModuleUpdate($destinationPath);
 
-        $this->logger->notice($this->translator->trans('Module %s update files have been fetched from %s.', [$moduleDownloaderContext->getModuleName(), $moduleSource->getPath()]));
+        $this->logger->notice($this->translator->trans('Module %s update files (%s => %s) have been fetched from %s.', [
+            $moduleDownloaderContext->getModuleName(),
+            $moduleDownloaderContext->getReferenceVersion(),
+            $moduleSource->getNewVersion(),
+            $moduleSource->getPath(),
+        ]));
     }
 
     /**

diff --git a/tests/unit/UpgradeTools/Module/ModuleDownloaderTest.php b/tests/unit/UpgradeTools/Module/ModuleDownloaderTest.php
@@ -72,7 +72,7 @@ public function testModuleDownloaderSucceedsOnFirstTryWithLocalFile()
 
         $this->logger->expects($this->once())
             ->method('notice')
-            ->with('Module mymodule update files have been fetched from ' . realpath(__DIR__ . '/../../../fixtures/mymodule') . '.');
+            ->with('Module mymodule update files (1.0.0 => 2.0.0) have been fetched from ' . realpath(__DIR__ . '/../../../fixtures/mymodule') . '.');
 
         $this->moduleDownloader->downloadModule($moduleContext);
 
@@ -93,7 +93,7 @@ public function testModuleDownloaderSucceedsOnFirstTryWithRemoteFile()
 
         $this->logger->expects($this->once())
             ->method('notice')
-            ->with('Module autoupgrade update files have been fetched from https://github.com/PrestaShop/autoupgrade/releases/download/v6.0.0/autoupgrade-v6.0.0.zip.');
+            ->with('Module autoupgrade update files (1.0.0 => 6.0.0) have been fetched from https://github.com/PrestaShop/autoupgrade/releases/download/v6.0.0/autoupgrade-v6.0.0.zip.');
 
         $this->moduleDownloader->downloadModule($moduleContext);
     }
@@ -143,7 +143,7 @@ public function testModuleDownloaderHandlesFallbacks()
             );
         $this->logger->expects($this->once())
             ->method('notice')
-            ->with('Module mymodule update files have been fetched from ' . realpath(__DIR__ . '/../../../fixtures/mymodule') . '.');
+            ->with('Module mymodule update files (1.0.0 => 2.0.0) have been fetched from ' . realpath(__DIR__ . '/../../../fixtures/mymodule') . '.');
 
         $this->moduleDownloader->downloadModule($moduleContext);
     }