fix: feedback from review

PrestaShop · Nov 20, 2024 · 25f5c1d · 25f5c1d
1 parent 7d270f1
commit 25f5c1d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/classes/Log/WebLogger.php b/classes/Log/WebLogger.php
@@ -89,12 +89,12 @@ public function log($level, string $message, array $context = []): void
         $message = $this->cleanFromSensitiveData($message);
         parent::log($level, $message, $context);
 
-        $log = $this->formatLog($level, $message);
-
         if ($level === self::INFO) {
-            $this->lastInfo = $log;
+            $this->lastInfo = $message;
         }
 
+        $log = $this->formatLog($level, $message);
+
         $this->normalMessages[] = $log;
 
         // deprecated : todo need to be removed after NEW UI is completed.

diff --git a/tests/unit/Log/WebLoggerTest.php b/tests/unit/Log/WebLoggerTest.php
@@ -33,7 +33,7 @@ public function testLastInfoIsRegistered()
         $logger = new WebLogger();
         $logger->log(WebLogger::INFO, 'Hello');
 
-        $this->assertSame('INFO - Hello', $logger->getLastInfo());
+        $this->assertSame('Hello', $logger->getLastInfo());
     }
 
     public function testSeveralLastInfoAreRegistered()
@@ -42,7 +42,7 @@ public function testSeveralLastInfoAreRegistered()
         $logger->log(WebLogger::INFO, 'Hello');
         $logger->log(WebLogger::INFO, 'Good bye');
 
-        $this->assertSame('INFO - Good bye', $logger->getLastInfo());
+        $this->assertSame('Good bye', $logger->getLastInfo());
         $infos = $logger->getInfos();
         $this->assertSame([
             'INFO - Hello',
@@ -101,7 +101,7 @@ public function testWholeLogContentIsProperlyOrdered()
         $logger->log(WebLogger::WARNING, 'Oh no 2');
         $logger->log(WebLogger::INFO, 'INFO #2');
 
-        $this->assertEquals('INFO - INFO #2', $logger->getLastInfo());
+        $this->assertEquals('INFO #2', $logger->getLastInfo());
 
         $this->assertEquals([
             'INFO - INFO #1',

diff --git a/views/templates/components/progress-bar.html.twig b/views/templates/components/progress-bar.html.twig
@@ -1,7 +1,7 @@
 <div data-component="progress-bar" class="progress log-progress__bar">
     <div class="progress-bar"
          role="progressbar"
-         data-title-template="{{ "Progress is {progress_percentage}%"|trans() }}"
+         data-title-template="{{ "Progress is {progress_percentage}%"|trans({}) }}"
          aria-valuenow="0"
          aria-valuemin="0"
          aria-valuemax="100"