Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockingMagician/unitConverter #98

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MockingMagician
Copy link

@MockingMagician MockingMagician commented Nov 24, 2021

The idea of this package is to provide a unit conversion.

Currently 3 families are implemented:

  • lengths
  • temperature
  • area

Comming next:

  • weight
  • volume
  • accelaration converter
  • time
  • pressure
  • memory/storage size
  • density
  • time

Capture d’écran de 2021-11-25 00-16-33

-designing package
- implementing conversion for lengths
- implementing general pattern for conversions
add temperature unities
fix unit family selected at statup
@MockingMagician
Copy link
Author

Hi @colinpape, @treygrainger, there is someone for checking pull request ?

@treygrainger
Copy link
Member

Hi @colinpape, @treygrainger, there is someone for checking pull request ?

@MockingMagician you ready for a review now, or still working on the other conversion metrics?

@MockingMagician
Copy link
Author

Hi @treygrainger

I plan to add all the units in the list, but doing it on my own time, you can do the code review and merge if the code is validated. The other units will be for 1.x versions

@treygrainger
Copy link
Member

@jejopl would you mind reviewing this when you have some time? Per @MockingMagician's comments, it seems like we could get what's there merged if it passes review and the other units could be added later.

@jejopl jejopl self-requested a review April 7, 2022 09:01
@MockingMagician
Copy link
Author

Hi @treygrainger, @jejopl

When is this PR, do you want to check it, do I continue it, do we merge this first version already?

The other units can be easily added with the system I set up.

If you want more units for its release tell me I will implement them. Just tell me if you are still interested ?

See you soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants