(feat) Plasma Desktop Theme Switcher #63
Open
+199
−85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an option to change the plasma desktop theme alongside the colour scheme when using the 'Switch Appearance' toggle.
Purpose
Some theme makers often provide light and dark variations of their desktop themes.
Unfortunately, this introduces an issue when toggling between appearances as these packages may contain hardcoded colour overrides, rendering the light/dark switch effectively useless.
This option allows the user to specify which desktop theme to use when triggering the appearance toggle, giving them better control over their light/dark visual preferences.
Changes
Most of the changes introduced in this PR are localised to files related to the appearance switcher function.
It also adds two configuration keys '(light|dark)PlasmaTheme' to 'config/main.xml' to store the user's desktop theme preferences.
Major(ish) changes:
Preview
(Note: Switching appearances is much faster than what is shown in this screencast. Having Spectacle record the screen, at the same time, seem to have slown it down by a fair bit.)
feat_plasma_theme_switcher.mp4