code review #62
Open
code review #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viknem31324
approved these changes
Nov 22, 2023
| return roundNumber(pay, 2); | ||
| } | ||
|
|
||
| double calculateSimplePercent(double amount, |
There was a problem hiding this comment.
аргумент метода лучше в одну строчку, если они помещаются в 120 символов
| double calculateSimplePercent(double amount, | ||
| double yearRate, int depositPeriod) { | ||
|
|
||
| return roundNumber(amount + amount |
There was a problem hiding this comment.
тут тоже думаю не стоит переносить
| Scanner scanner = new Scanner(System.in); | ||
|
|
||
| System.out.println("Введите сумму вклада в рублях:"); | ||
| amount = scanner.nextInt(); |
There was a problem hiding this comment.
на мой взгляд приятнее читать код, когда написано int amount = scanner.nextInt(); Сразу видишь какой тип, глазами не бегаешь на верх. Тут, наверное, дело вкуса.
There was a problem hiding this comment.
Ну да, кому как. Мне, например, удобнее так, но услышал тебя, спасибо.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.