-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CompareText.tests.ps1 work #37
base: main
Are you sure you want to change the base?
Conversation
@per-oestergaard please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
PR Summary
I am not sure why the tests does not work. It seems to be related to when $TestCases is set and perhaps it is related to Pester v5. Anyway, the tests now work by 'elevating' the $TestCases variables so they are available during the discovery phase.
I also added Import-Module, but that is just because I am not sure how that should fit in. If that is the wrong place, please just delete the line again.
I also snug into .gitignore that is should ignore my .devcontainer. I am working on Ubuntu 22.04 with vscode and thus wanted to isolate the environment in a container.
I did change the casing of
test/TextTableParser.Tests.ps1
to lowercase 'tests' to align with the other files. However, I switched back so the diff can show the changes I made.PR Context
I was planning to create a PR on another issue but before doing so, I wanted to ensure I could run the tests successfully.