-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] WMI adapter improvements #520
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 9443e1c.
@anmenaga Hey Andrew, I definitely didn’t want to step on your toes, but while I was testing the WMI adapter, I thought I'd contribute a bit. Would you mind taking a look at my initial commit when you have a moment? |
@michaeltlombardi Hey Mikey, I could not attend the DSC community call last week so was unable to ask the question here. In the wmi.resource.ps1 file, resources are listed in a I don't know if this is something that can be changed. In the current PR, I coined to use If it's something to be discussed into a discussion, then that's also fine. |
@Gijsreyn I appreciate you taking the time to help improve the WMI adapter, however, I think it would be more productive for us if you can make smaller targeted changes making it easier to review and get merged in rather than one large PR that will take a lot longer to review and iterate. |
@SteveL-MSFT Thanks for the response. I get the point, thought of picking most of the content what was already available from the |
PR Summary
Starting to address #475 and new
wmiAdapter
module includedPR Context