New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GeoIP2 lookup issues #415

Merged

neilcook merged 6 commits into PowerDNS:master from neilcook:geoip

Jan 3, 2024

Merged

Fix GeoIP2 lookup issues #415

Update latitude for geoip test

GitHub Actions / Test Results failed Jan 3, 2024 in 0s

4 fail, 66 pass in 15m 35s

70 tests ±0 66 ✅ - 1 15m 35s ⏱️ -30s
1 suites ±0 0 💤 ±0
1 files ±0 4 ❌ +1

Results for commit 06a7d1e. ± Comparison against earlier commit ea8166d.

Annotations

Check warning on line 0 in test_GeoIP.TestGeoIP

github-actions / Test Results

test_geoIP (test_GeoIP.TestGeoIP) failed

artifacts/Test Results/gcctest.xml [took 0s]

Raw output


            AssertionError: Regex didn't match: 'Japan' not found in '{"msg": "diffPasswords for login", "r_attrs": {}, "status": -1}'
self = <test_GeoIP.TestGeoIP testMethod=test_geoIP>

    def test_geoIP(self):
        # don't allow IPs from Japan (arbitrary)
        r = self.allowFunc('baddie', '112.78.112.20', "1234")
        j = r.json()
        self.assertEqual(j['status'], -1)
>       self.assertRegex(json.dumps(j), "Japan")
E       AssertionError: Regex didn't match: 'Japan' not found in '{"msg": "diffPasswords for login", "r_attrs": {}, "status": -1}'

test_GeoIP.py:17: AssertionError

Check warning on line 0 in test_GeoIP.TestGeoIP

github-actions / Test Results

test_geoIP2City (test_GeoIP.TestGeoIP) failed

artifacts/Test Results/gcctest.xml [took 0s]

Raw output


            AssertionError: Regex didn't match: 'Nottingham' not found in '{"r_attrs": {"city": ""}, "success": true}'
self = <test_GeoIP.TestGeoIP testMethod=test_geoIP2City>

    def test_geoIP2City(self):
        attrs = dict()
        attrs['ip'] = '128.243.1.1'
        r = self.customFuncWithName("geoip2", attrs)
        j = r.json()
>       self.assertRegex(json.dumps(j), "Nottingham")
E       AssertionError: Regex didn't match: 'Nottingham' not found in '{"r_attrs": {"city": ""}, "success": true}'

test_GeoIP.py:25: AssertionError

Check warning on line 0 in test_GeoIP.TestGeoIP

github-actions / Test Results

test_geoIP2LookupVals (test_GeoIP.TestGeoIP) failed

artifacts/Test Results/gcctest.xml [took 0s]

Raw output


            AssertionError: Regex didn't match: 'Nottingham' not found in '""'
self = <test_GeoIP.TestGeoIP testMethod=test_geoIP2LookupVals>

    def test_geoIP2LookupVals(self):
        attrs = dict()
        attrs['ip'] = '128.243.21.1'
        r = self.customFuncWithName("geoip2_lookupValue", attrs)
        j = r.json()
        print(json.dumps(j))
>       self.assertRegex(json.dumps(j['r_attrs']['city']), "Nottingham")
E       AssertionError: Regex didn't match: 'Nottingham' not found in '""'

test_GeoIP.py:34: AssertionError

Check warning on line 0 in test_Replication.TestTimeWindowsReplication

github-actions / Test Results

test_expiry (test_Replication.TestTimeWindowsReplication) failed

artifacts/Test Results/gcctest.xml [took 16s]

Raw output


            AssertionError: 0 != -1
self = <test_Replication.TestTimeWindowsReplication testMethod=test_expiry>

    def test_expiry(self):
        r = self.allowFunc('expirebaddiereplication', '127.0.0.1', "1234")
        j = r.json()
        self.assertEqual(j['status'], 0)
        r.close()
    
        for i in range(20):
            r = self.reportFunc('expirebaddiereplication%s' % i, "127.0.0.1", "1234", True)
            r.json()
        for i in range(20):
            r = self.reportFunc('expirebaddiereplication%s' % i, "127.0.0.1", "1234", True)
            r.json()
    
        r = self.allowFuncReplica('expirebaddiereplication', '127.0.0.1', "1234")
        j = r.json()
        self.assertEqual(j['status'], -1)
    
        r = self.allowFuncReplica2('expirebaddiereplication', '127.0.0.1', "1234")
        j = r.json()
>       self.assertEqual(j['status'], -1)
E       AssertionError: 0 != -1

test_Replication.py:233: AssertionError

Check notice on line 0 in .github

github-actions / Test Results

70 tests found

There are 70 tests, see "Raw output" for the full list of tests.

Raw output


            test_8bit.TestEightBit ‑ test8Bit
test_Attrs.TestAttrs ‑ test_Attrs
test_Basics.TestBasics ‑ testChunked
test_Basics.TestBasics ‑ test_auth_stats
test_Basics.TestBasics ‑ test_customFunc
test_Basics.TestBasics ‑ test_customGetFunc
test_Basics.TestBasics ‑ test_deviceParsing
test_Basics.TestBasics ‑ test_getBL
test_Basics.TestBasics ‑ test_getDBStats
test_Basics.TestBasics ‑ test_ping
test_Basics.TestBasics ‑ test_ping_acl_deny
test_Basics.TestBasics ‑ test_unauth
test_Blacklist.TestBlacklist ‑ test_IPBlacklist
test_Blacklist.TestBlacklist ‑ test_IPLoginBlacklist
test_Blacklist.TestBlacklist ‑ test_LoginBlacklist
test_Blacklist.TestBlacklist ‑ test_NetmaskBlacklist
test_Blacklist.TestBlacklist ‑ test_PersistBlacklist
test_Block.TestBlock ‑ test_block
test_DNSLookups.TestDNSLookups ‑ test_DNSLookups
test_DNSLookups.TestDNSLookups ‑ test_DNSRetries
test_DumpEntries.TestDumpEntries ‑ test_dumpentries
test_GeoIP.TestGeoIP ‑ test_geoIP
test_GeoIP.TestGeoIP ‑ test_geoIP2City
test_GeoIP.TestGeoIP ‑ test_geoIP2LookupVals
test_LogLevel.TestBasics ‑ test_debug
test_LogLevel.TestBasics ‑ test_error
test_LogLevel.TestBasics ‑ test_info
test_LogLevel.TestBasics ‑ test_warning
test_Prometheus.TestPrometheus ‑ test_RealPrometheus
test_Prometheus.TestPrometheus ‑ test_TrackalertMetrics
test_Prometheus.TestPrometheus ‑ test_WforceMetrics
test_Replication.TestTimeWindowsReplication ‑ test_AddRemoveSiblings
test_Replication.TestTimeWindowsReplication ‑ test_BlackWhitelist
test_Replication.TestTimeWindowsReplication ‑ test_FailedLogins
test_Replication.TestTimeWindowsReplication ‑ test_PrefixMappedv4
test_Replication.TestTimeWindowsReplication ‑ test_Prefixv4
test_Replication.TestTimeWindowsReplication ‑ test_Prefixv6
test_Replication.TestTimeWindowsReplication ‑ test_Reset
test_Replication.TestTimeWindowsReplication ‑ test_SetSiblings
test_Replication.TestTimeWindowsReplication ‑ test_diffIPs
test_Replication.TestTimeWindowsReplication ‑ test_expiry
test_Replication.TestTimeWindowsReplication ‑ test_invalidPasswords
test_Replication.TestTimeWindowsReplication ‑ test_resetField
test_Replication.TestTimeWindowsReplication ‑ test_subTest
test_SyncDBs.TestSyncDBs ‑ test_SyncDBs
test_TimeWindows.TestTimeWindows ‑ test_FailedLogins
test_TimeWindows.TestTimeWindows ‑ test_PrefixMappedv4
test_TimeWindows.TestTimeWindows ‑ test_Prefixv4
test_TimeWindows.TestTimeWindows ‑ test_Prefixv6
test_TimeWindows.TestTimeWindows ‑ test_Reset
test_TimeWindows.TestTimeWindows ‑ test_ResetField
test_TimeWindows.TestTimeWindows ‑ test_diffIPs
test_TimeWindows.TestTimeWindows ‑ test_expiry
test_TimeWindows.TestTimeWindows ‑ test_invalidPasswords
test_TimeWindows.TestTimeWindows ‑ test_subTest
test_Trackalert.TestTrackalert ‑ test_auth_stats
test_Trackalert.TestTrackalert ‑ test_trackalertBackgroundFuncs
test_Trackalert.TestTrackalert ‑ test_trackalertCustomFunc
test_Trackalert.TestTrackalert ‑ test_trackalertReport
test_Trackalert.TestTrackalert ‑ test_wforceToTrackalert
test_WebHooks.TestWebHooks ‑ test_customwebhooks
test_WebHooks.TestWebHooks ‑ test_kafka_webhooks
test_WebHooks.TestWebHooks ‑ test_mtls_webhook
test_WebHooks.TestWebHooks ‑ test_namedreportsinks
test_WebHooks.TestWebHooks ‑ test_webhooks
test_Whitelist.TestWhitelist ‑ test_IPLoginBlacklist
test_Whitelist.TestWhitelist ‑ test_IPWhitelist
test_Whitelist.TestWhitelist ‑ test_LoginWhitelist
test_Whitelist.TestWhitelist ‑ test_NetmaskWhitelist
test_Whitelist.TestWhitelist ‑ test_PersistWhitelist

View more details on GitHub Actions