Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues with libdrogon #410

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Conversation

neilcook
Copy link
Collaborator

@neilcook neilcook commented Nov 30, 2023

Libdrogon 1.7.4 fails to build on ol-8 and ol-9, however the most recent version 1.9.1 does not build on centos-7 and amazon-2 because that requires openssl-1.1 which is not available on those OSs. This PR updates to 1.9.1 everywhere except when building amazon-2 and centos-7 packages.

Also updates yaml-cpp to the latest version and fixes some missing std:: references in the json11 code.

Copy link

github-actions bot commented Nov 30, 2023

Test Results

    2 files  ±0      2 suites  ±0   32m 5s ⏱️ +31s
  69 tests ±0    69 ✔️ +1  0 💤 ±0  0  - 1 
138 runs  ±0  138 ✔️ +1  0 💤 ±0  0  - 1 

Results for commit 42fe8df. ± Comparison against base commit 40c18ee.

♻️ This comment has been updated with latest results.

Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neilcook neilcook merged commit 3f59347 into PowerDNS:master Dec 5, 2023
10 checks passed
@neilcook neilcook deleted the drogon branch December 5, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants