Merge pull request #9 from wojas/remove-lmdbpool

Remove exp/lmdbpool
PowerDNS · Apr 20, 2021 · e6e70de · e6e70de
2 parents 33d501a + 84a9e1c
commit e6e70de
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 406 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -7,6 +7,7 @@ First release of this PowerDNS/lmdb-go fork.
 - Renamed module from `github.com/bmatsuo/lmdb-go` to `github.com/PowerDNS/lmdb-go` (#3, PR #7)
 - Add `go.mod` and fix tests and Travis CI on recent Go versions (#5, PR #6)
 - Fix: Cursor.Put would write "\x00" instead of an empty value (#1, PR #2)
+- Remove experimental, never released `exp/lmdbpool` package (PR #9)
 - lmdb: Update LMDB C library to version 0.9.28 (#4).
 
 ```

diff --git a/README.md b/README.md
@@ -18,6 +18,9 @@ To use this package, update all your import paths from
 
 This affects all versions starting from 1.9.0.
 
+Note that the experimental, never released `exp/lmdbpool` package has
+been removed in this fork.
+
 
 ## Packages
 
@@ -49,25 +52,6 @@ A utility package for scanning database ranges. The API is inspired by
 [bufio.Scanner](https://godoc.org/bufio#Scanner) and the python cursor
 [implementation](https://lmdb.readthedocs.org/en/release/#cursor-class).
 
-#### exp/lmdbpool [![GoDoc](https://godoc.org/github.com/PowerDNS/lmdb-go/exp/lmdbpool?status.svg)](https://godoc.org/github.com/PowerDNS/lmdb-go/exp/lmdbpool) [![experimental](https://img.shields.io/badge/stability-experimental-red.svg)](#user-content-versioning-and-stability)
-
-
-```go
-import "github.com/PowerDNS/lmdb-go/exp/lmdbpool"
-```
-
-A utility package which facilitates reuse of lmdb.Txn objects using a
-sync.Pool.  Naively storing lmdb.Txn objects in sync.Pool can be troublesome.
-And the lmdbpool.TxnPool type has been defined as a complete pooling solution
-and as reference for applications attempting to write their own pooling
-implementation.
-
-The lmdbpool package is relatively new.  But it has a lot of potential utility.
-And once the lmdbpool API has been ironed out, and the implementation hardened
-through use by real applications it can be integrated directly into the lmdb
-package for more transparent integration.  Please test this package and provide
-feedback to speed this process up.
-
 #### exp/lmdbsync [![GoDoc](https://godoc.org/github.com/PowerDNS/lmdb-go/exp/lmdbsync?status.svg)](https://godoc.org/github.com/PowerDNS/lmdb-go/exp/lmdbsync) [![experimental](https://img.shields.io/badge/stability-experimental-red.svg)](#user-content-versioning-and-stability)
 
 

diff --git a/exp/lmdbpool/doc.go b/exp/lmdbpool/doc.go
diff --git a/exp/lmdbpool/put.go b/exp/lmdbpool/put.go
diff --git a/exp/lmdbpool/putrace.go b/exp/lmdbpool/putrace.go