Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin/ts): error handling when querying version matching #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Dec 3, 2023

No description provided.

console.log('text', result)
const matchVersion = suggestedVersions.filter(({ id }) => id.includes(result.text))
matchVersion.length > 0
? onChange?.(matchVersion[0]?.value.toString())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不可以直接强行切换到对应版本吗?🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以,但是如果他输入任何以外的值都给一个固定值,是不是不太符合直觉?

要不然在不匹配任何值的时候给一个固定@latest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

预期的话应该是不管怎么样都设置过去,然后应该会触发 monaco 的加载,最后如果有版本那就会找到对应的版本并加载,如果找不到那么就会在下面编辑框的位置出现一些提示出来,我之前应该是做了这个异常逻辑的 fallback 的。

const loadingNode = useMemo(() => typescriptVersion ? null : <section style={{
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
flexDirection: 'column'
}}>
<div style={{
position: 'relative',
width: 72,
height: 72,
backgroundColor: '#4272ba',
userSelect: 'none'
}}>
<span style={{
position: 'absolute',
right: 5,
bottom: -2,
fontSize: 30,
fontWeight: 'blob'
}}>TS</span>
</div>
{loadError
? <span>{loadError}</span>
: <span>Downloading TypeScript{typescriptVersion && <>@<code>{typescriptVersion}</code></>} ...</span>}
</section>, [loadError, typescriptVersion])

可以检查一下能否强制切换到这个 fallback 逻辑。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 我看下

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最终 loadingNode 会被加载到这个地方来

loading={loadingNode}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants