Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary "\n" at the end of some echo statements #30

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Remove unnecessary "\n" at the end of some echo statements #30

wants to merge 18 commits into from

Conversation

lc-at
Copy link

@lc-at lc-at commented Jan 4, 2022

Summary

As you can see in the diff section, this PR simply removes \n in echo statements in the make_editor_choice() and get_editor_choice() functions. This \n is literally printed as \n and not a new line.

Which editor do you want to use for this repo?\n
1. VI\n
2. NANO\n
3. Your own\n
You Choose:

This PR removes that unnecessary \n.

My bash version

GNU bash, version 5.1.4(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

AaronVasquez and others added 18 commits October 31, 2017 15:55
@AaronVasquez
Merge pull request PotatoLabs#9 from jordiprats/master
8f41f99 
Added a option to edit all the commits
@AaronVasquez
Merge pull request PotatoLabs#8 from beingmrkenny/master
1200498 
Translating "now" keyword to a valid timestamp
Update git-redate
7b67eb8 
Fixed PotatoLabs#13
@AaronVasquez
Merge pull request PotatoLabs#14 from aios/patch-1
41914a7 
Update git-redate
Make choice for two editors
3301af0 
Vi is a flexible and scalable editor. But it requires certain skills in order to use it.
So i added choice between Vi and Nano.
@AaronVasquez
Merge pull request PotatoLabs#15 from aios/patch-1
7ac0e23 
Make choice for two editors
Added commits chunks, Debug mode, etc
5d9b010 
- Chunks collection
- Debug operation (Operation progress)
- Fix bug with last line (last commit) in tempfile
- Added some params

Tested on 2000+ commits - spent some time (5 min) but working.
fixed PotatoLabs#16
@AaronVasquez
Merge pull request PotatoLabs#17 from aios/patch-2
594b611 
Added commits chunks, Debug mode, etc
@olivergg
Use the standard environment variables EDITOR instead of asking the user
5708666
@EdmundMai
Merge pull request PotatoLabs#18 from olivergg/use_editor_env
b662874 
Use the standard environment variable EDITOR instead of asking the user
@4ndrej
user-wide settings file
f900c21
@EdmundMai
Merge pull request PotatoLabs#19 from 4ndrej/patch-1
ad3155a 
user-wide settings file
@prince-chrismc
adding third option to specify any test editor
4bef29b
@prince-chrismc
adding snippet for windows install
72de64e
@EdmundMai
Merge pull request PotatoLabs#22 from prince-chrismc/master
a6a33a0 
adding third option to specify any test editor
@simnalamburt
Replace preview image
8e8077f 
TinyPic Has Ceased Operations

Reference:
  https://tinypic.com/
@EdmundMai
Merge pull request PotatoLabs#25 from simnalamburt/patch-1
71d4a66 
Replace preview image
@lc-at
Remove "\n" at the end of some echo statements
6985e34
@lc-at lc-at force-pushed the patch-literal-newline branch from 2e399d0 to 6985e34 Compare November 2, 2023 04:15
@tomeon tomeon mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lc-at @AaronVasquez @olivergg @EdmundMai @4ndrej @prince-chrismc @simnalamburt