feat: log pool maximum size #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
force-pushed
the
pool-logs
branch
from
8127738
to
c4ef9c0
Compare
It's not immediately clear on which port the API server is listening. Also it's not clear that the "pgrst" channel is for database notifications. Goes from: <timestamp>: Admin server listening on 0.0.0.0:3001 <timestamp>: Listening on 0.0.0.0:3000 <timestamp>: Listening for notifications on the "pgrst" channel To: <timestamp>: Admin server listening on 0.0.0.0:3001 <timestamp>: API server listening on 0.0.0.0:3000 <timestamp>: Listening for database notifications on the "pgrst" channel
It's important for observability to have an historic trace of the pool size. Currently we expose it on the metrics endpoint, but not all deployments use it. This logs the pool size after the successful connection log to make it more visible: <timestamp>: Connection Pool initialized with a maximum size of 4 connections
steve-chavez
force-pushed
the
pool-logs
branch
from
c4ef9c0
to
0b82886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important for observability to have an historic trace of the pool size. Currently we expose it on the metrics endpoint, but not all deployments use it.
This logs the pool size after the successful connection log to make it more visible: