Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Raise limit for memory tests #3647

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

wolfgangwalther
Copy link
Member

Currently, two of the memory tests are failing with slightly more than 20M used:

I repeated this a few times - no chance. It always fails the same. It also fails when I run this test locally. And it also fails when I checkout older commits, before the merges I made yesterday and run the tests there.

The memory tests for all commits on main have passed before the PRs were merged. The pipelines on main didn't run through for b598b59 and ee4bfbf - in fact they are still in an odd pending queued state for many hours. The last time that the memory test was run in CI was for 0dc1345 in https://github.com/PostgREST/postgrest/actions/runs/9842378222. All good.

Literally the only change since the last time the memory tests ran successfully is... time. 1-2 days have passed and now the memory tests fail consistently.

That's quite odd, but I can't figure out why. So just bumping the memory limits for those tests for now.

@wolfgangwalther wolfgangwalther merged commit b135d9b into PostgREST:main Jul 9, 2024
13 checks passed
@wolfgangwalther wolfgangwalther deleted the memory-test branch July 9, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants