Backport to v12 #3646
Merged
Backport to v12 #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be loaded from in-database configuration first, otherwise the dump-schema output will be for the default (public) schema.
There is no reason to hide those, right?
… present The schema cache and OpenAPI output would currently list the first found enum with the same name instead of the correct type. One other case where this comes up is when a regular type and an enum type have the same name. For example in the spec fixtures, we have an enum called "bit". Every "bit" type, no matter whether it's that enum or the built-in bit type, will show those enum options in the OpenApi output. Not adding a test, because OpenAPI is supposed to go away in the future anyway.
Fully agree with that. |
|
Any reason why shouldn't we release a new patch version now? The fixes and the perf increase are really good. |
Patch release? Sure, go ahead. The performance commit is not a fix, though, and thus not backpatched. It's only part of main. I sure don't want to release a major now, we might have more breaking changes to consider before doing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the fixes from #3639 and #3644 to v12.
I think we should make it a policy to backport fix commits immediately after merging them to main. We don't need to release on the backbranch immediately, but we should at least open the PR with the backport. This is because at this time, the changes are much more recent and easier to deal with in case they fail tests or so on the backbranch.