-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow megaparsec 9.6 #23
Conversation
@robx How would I make a release to hackage after I merge? This is not automated, is it? Would you do that manually? |
@wolfgangwalther I can make the hackage release (Robert added me as maintainer). I'll do it manually after you merge, though ideally we automate this. |
Yeah, agreed. Should probably be easier to test your suggestions in PostgREST/postgrest#2275 (comment) here than in the main repo. |
For now, I merged - feel free to either manually release or try one of the actions. |
@wolfgangwalther @laurenceisla Do you guys have an account on Hackage? I can add you as maintainer. |
@steve-chavez I requested an account creation. I guess, it'll take a bit to receive a confirmation since it seems to be a manual process. |
@steve-chavez @laurenceisla bump. Can one of you do a hackage release? |
In fact, it would be enough to make a new revision only. |
@wolfgangwalther I made the new revision: https://hackage.haskell.org/package/configurator-pg-0.2.9/revisions/ But it didn't let me remove the unused 'bytestring' dependency for tests, so I left it there.
If removing it is needed then I'll make a new release instead. |
Ah, interesting. Yes, the bytestring dependency must either be bumped higher or be removed. Otherwise the build with GHC 9.8.1 will fail. So yes, a new release would be the best option, then. Thanks! |
Hm. It seems to have worked with the revision, too.. https://github.com/PostgREST/postgrest/actions/runs/7962491871/job/21736091141?pr=3236 |
Ah, of course - because we don't run the tests there. But we still need a new version, so that this can make it into nixpkgs eventually when we want to build with GHC 9.8.1 via nix. So yeah a new release would be best. |
I got permission to upload to hackage at last. I modified the relevant files in #24 Edit: Already published to https://hackage.haskell.org/package/configurator-pg-0.2.10 |
I'm currently trying to build PostgREST with GHC 9.8.1 - this is the last dependency remaining to make this work, I think.