Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow megaparsec 9.6 #23

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Allow megaparsec 9.6 #23

merged 2 commits into from
Jan 22, 2024

Conversation

wolfgangwalther
Copy link
Member

I'm currently trying to build PostgREST with GHC 9.8.1 - this is the last dependency remaining to make this work, I think.

@wolfgangwalther
Copy link
Member Author

@robx How would I make a release to hackage after I merge? This is not automated, is it? Would you do that manually?

@steve-chavez
Copy link
Member

@wolfgangwalther I can make the hackage release (Robert added me as maintainer). I'll do it manually after you merge, though ideally we automate this.

@wolfgangwalther
Copy link
Member Author

Yeah, agreed. Should probably be easier to test your suggestions in PostgREST/postgrest#2275 (comment) here than in the main repo.

@wolfgangwalther wolfgangwalther merged commit e4d2dd3 into master Jan 22, 2024
5 checks passed
@wolfgangwalther wolfgangwalther deleted the ghc981 branch January 22, 2024 20:52
@wolfgangwalther
Copy link
Member Author

For now, I merged - feel free to either manually release or try one of the actions.

@steve-chavez
Copy link
Member

@wolfgangwalther @laurenceisla Do you guys have an account on Hackage? I can add you as maintainer.

@laurenceisla
Copy link
Member

@steve-chavez I requested an account creation. I guess, it'll take a bit to receive a confirmation since it seems to be a manual process.

@wolfgangwalther
Copy link
Member Author

@steve-chavez @laurenceisla bump. Can one of you do a hackage release?

@wolfgangwalther
Copy link
Member Author

In fact, it would be enough to make a new revision only.

@laurenceisla
Copy link
Member

@wolfgangwalther I made the new revision: https://hackage.haskell.org/package/configurator-pg-0.2.9/revisions/

But it didn't let me remove the unused 'bytestring' dependency for tests, so I left it there.

hackage Cannot remove existing library dependency on 'bytestring' in test suite 'tests' component

If removing it is needed then I'll make a new release instead.

@wolfgangwalther
Copy link
Member Author

Ah, interesting. Yes, the bytestring dependency must either be bumped higher or be removed. Otherwise the build with GHC 9.8.1 will fail. So yes, a new release would be the best option, then.

Thanks!

@wolfgangwalther
Copy link
Member Author

Hm. It seems to have worked with the revision, too..

https://github.com/PostgREST/postgrest/actions/runs/7962491871/job/21736091141?pr=3236

@wolfgangwalther
Copy link
Member Author

Ah, of course - because we don't run the tests there. But we still need a new version, so that this can make it into nixpkgs eventually when we want to build with GHC 9.8.1 via nix. So yeah a new release would be best.

@laurenceisla laurenceisla mentioned this pull request Mar 7, 2024
@laurenceisla
Copy link
Member

laurenceisla commented Mar 7, 2024

I got permission to upload to hackage at last. I modified the relevant files in #24 and uploaded a candidate https://hackage.haskell.org/package/configurator-pg-0.2.10/candidate in the meantime.

Edit: Already published to https://hackage.haskell.org/package/configurator-pg-0.2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants