Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devex): hogvm into common folder #27721

Merged
merged 13 commits into from
Jan 21, 2025
Merged

chore(devex): hogvm into common folder #27721

merged 13 commits into from
Jan 21, 2025

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Jan 21, 2025

Problem

We want to move the scattered library projects in the posthog monorepo into a common/ folder.

Changes

Second step. Moving over:

The nr of changed files might be daunting, but it's mostly just tests and snapshots for the HogVM

How did you test this code?

CI tests pass. I don't expect any problems here since:

  • All TS projects (frontend and plugin-server) use the HogVM from npm and are unaffected.
  • The python HogVM is not used anywhere, and the changes to a few import paths where quite clear

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Size Change: +766 B (+0.07%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB +766 B (+0.07%)

compressed-size-action

@mariusandra mariusandra changed the base branch from common-parser to master January 21, 2025 12:45
@mariusandra mariusandra marked this pull request as ready for review January 21, 2025 13:00
@PostHog PostHog deleted a comment from posthog-bot Jan 21, 2025
@mariusandra mariusandra enabled auto-merge (squash) January 21, 2025 14:03
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@mariusandra mariusandra merged commit 788ea28 into master Jan 21, 2025
100 checks passed
@mariusandra mariusandra deleted the common-hogvm branch January 21, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants