fix: Frontend scripts and Tailwind accounting for products/
#27696
Conversation
package.json
Outdated
| "prettier --write" | ||
| ], | ||
| "products/**/frontend/**/*.{js,jsx,mjs,ts,tsx}": [ | ||
| "eslint --cache products/**/frontend/**/* -c .eslintrc.js --fix", | ||
| "prettier --write products" |
There was a problem hiding this comment.
This runs prettier on the whole products/ directory for each file changed under products/**/frontend/**/... – which is why this PR contains changes to a README.md, which wasn't otherwise changed.
| "prettier --write products" | |
| "prettier --write" |
Curious why we need a separate Eslint cache BTW, if the original formatting command here didn't specify the cache path?
There was a problem hiding this comment.
We don't need a separate cache. Lemme fix.
|
Size Change: +5 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
package.json
Outdated
| "eslint -c .eslintrc.js --fix", | ||
| "prettier --write" | ||
| "eslint -c .eslintrc.js --fix cypress/**/*", | ||
| "prettier --write \"cypress/**/*.{js,mjs,ts,tsx,json,yaml,yml,css,scss}\"" |
There was a problem hiding this comment.
This specification of path also is unwanted, since lint-staged already provides the path of every changed file. Same in eslint above
There was a problem hiding this comment.
Thanks. I've fixed paths.
skoob13
force-pushed
the
chore/products-folder-scripts
branch
from
90e8d80 to
b4c35ae
Compare
Twixes
changed the title
products/
Problem
Frontend scripts don't work for the
/products/**dir.Changes
I might've missed some other scripts.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Locally