Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove billingLogic from sceneLogic #27622

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+2 −13
Open

chore: remove billingLogic from sceneLogic #27622

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb8e766
chore: remove billingLogic from sceneLogic
joshsny Jan 16, 2025
d71fc0a
Merge branch 'master' into stop-hitting-billing
joshsny Jan 16, 2025
f5f44f7
Merge branch 'master' into stop-hitting-billing
joshsny Jan 17, 2025
6da9a03
Update UI snapshots for `chromium` (2)
github-actions[bot] Jan 17, 2025
efe3213
Update UI snapshots for `chromium` (2)
github-actions[bot] Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions frontend/src/scenes/sceneLogic.ts
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure there's nothing like features etc that we need on all screens that comes from billing? eg feature info

Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@ import { urls } from 'scenes/urls'
import { ProductKey } from '~/types'

import { handleLoginRedirect } from './authentication/loginLogic'
import { billingLogic } from './billing/billingLogic'
import { SOURCE_DETAILS, sourceWizardLogic } from './data-warehouse/new/sourceWizardLogic'
import { onboardingLogic, OnboardingStepKey } from './onboarding/onboardingLogic'
import { OnboardingStepKey } from './onboarding/onboardingLogic'
import { organizationLogic } from './organizationLogic'
import { preflightLogic } from './PreflightCheck/preflightLogic'
import type { sceneLogicType } from './sceneLogicType'
Expand Down Expand Up @@ -52,14 +51,7 @@ export const sceneLogic = kea<sceneLogicType>([
sourceWizardLogic,
['selectConnector', 'handleRedirect', 'setStep'],
],
values: [
featureFlagLogic,
['featureFlags'],
billingLogic,
['billing'],
organizationLogic,
['organizationBeingDeleted'],
],
values: [featureFlagLogic, ['featureFlags'], organizationLogic, ['organizationBeingDeleted']],
})),
actions({
/* 1. Prepares to open the scene, as the listener may override and do something
Expand Down Expand Up @@ -292,9 +284,6 @@ export const sceneLogic = kea<sceneLogicType>([
console.warn(
`Onboarding not completed for ${productKeyFromUrl}, redirecting to onboarding intro`
)
onboardingLogic.mount()
onboardingLogic.actions.setIncludeIntro(!!values.billing)
onboardingLogic.unmount()

if (
scene === Scene.DataWarehouseTable &&
Expand Down
Loading