Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make canvas more visible #27366

Merged
merged 4 commits into from
Jan 8, 2025
Merged

fix: Make canvas more visible #27366

merged 4 commits into from
Jan 8, 2025

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Jan 8, 2025

Problem

Better than #27365

Canvas is great and I want to make it a little more visible.

Changes

2025-01-08 16 28 20

  • Fixes some bugs with the canvas editing
  • Adds a "new canvas" button
  • Adds a share button there.

For the future I might actually think about swapping to canvas as the default with Notebooks as the "saved" version of one...

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite enabled auto-merge (squash) January 8, 2025 17:00
@benjackwhite benjackwhite merged commit e862480 into master Jan 8, 2025
99 checks passed
@benjackwhite benjackwhite deleted the feat/canvas-url branch January 8, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants