refactor: PostgreSQL batch export with SPMC abstractions #27348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossgray
approved these changes
Jan 8, 2025
| if batch_export.destination.type in ("BigQuery", "Redshift") | ||
| else SYNC_BATCH_EXPORTS_TASK_QUEUE | ||
| ) | ||
| task_queue = SYNC_BATCH_EXPORTS_TASK_QUEUE if batch_export.destination.type == "HTTP" else BATCH_EXPORTS_TASK_QUEUE |
There was a problem hiding this comment.
will the task queue only be updated if a user manually syncs or updates the batch export?
There was a problem hiding this comment.
Yeah. But we can run a script to update everything ourselves once this PR is merged.
tomasfarias
force-pushed
the
feat/spmc-for-postgresql-batch-export
branch
from
4bcb9e3 to
a4bc9c1
Compare
tomasfarias
force-pushed
the
feat/spmc-for-postgresql-batch-export
branch
from
d759b49 to
c624b6d
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Final PR to add SPMC abstractions (well, except for HTTP batch export, but those are created more on-demand). This one targets PostgreSQL.
Changes
PostgreSQLConsumerthat inherits fromspmc.Consumer.run_consumer.BATCH_EXPORT_POSTGRES_RECORD_BATCH_QUEUE_MAX_SIZE_BYTESsetting.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Tests are passing.