fix: Prevent exception when IP address is 192.168.x.x

[danielbachhuber]

Changes

Avoids an exception when the IP address is 192.168.x.x. I'm sending in some events locally using a script.

How did you test this code?

Tests should pass.

[neilkakkar]

what happens when the exception is raised? It should get caught in the flow somewhere

[danielbachhuber]

what happens when the exception is raised? It should get caught in the flow somewhere

@neilkakkar I just saw it in the logs while I was debugging why event definition creation wasn't happening. It may break event definition creation for this edge case but I don't know enough about how that system works yet to properly evaluate.

[neilkakkar]

I don't think this has anything to do with event definitions 🤔 , different code paths.

This function logs exceptions without raising them, so I think that's what you saw, vs the raised exception itself. I don't think its worth adding any exceptions here, I'd rather this gets logged so we're aware of what's coming in for ip resolution. It's an issue if this is happening in production (because say maybe ip resolving isn't working correctly due to a proxy/whatever)

[danielbachhuber]

I don't think its worth adding any exceptions here, I'd rather this gets logged so we're aware of what's coming in for ip resolution

@neilkakkar Sounds good 👍