Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(insights): fix shared insights with color themes #27231

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix(insights): fix shared insights with color themes #27231

merged 1 commit into from
Jan 2, 2025

Conversation

thmsobrmlr
Copy link
Contributor

Problem

The default theme can't be determined on shared insights as is_global isn't available

Changes

Adds it

How did you test this code?

Tried locally

@thmsobrmlr thmsobrmlr requested a review from a team January 2, 2025 21:22
aspicer
aspicer approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@aspicer aspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thmsobrmlr thmsobrmlr enabled auto-merge (squash) January 2, 2025 21:24
@thmsobrmlr thmsobrmlr merged commit ec7e22c into master Jan 2, 2025
92 of 93 checks passed
@thmsobrmlr thmsobrmlr deleted the hotfix-themes-public-serializer branch January 2, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspicer aspicer aspicer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @aspicer