Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(modeling): only set last run at after task completes #27229

Merged
merged 5 commits into from
Jan 3, 2025
Merged

chore(modeling): only set last run at after task completes #27229

merged 5 commits into from
Jan 3, 2025

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jan 2, 2025

Problem

  • last run at is always set

Changes

  • only set after job is finished

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE mentioned this pull request Jan 2, 2025
Closed
@EDsCODE EDsCODE requested a review from Gilbert09 January 2, 2025 19:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 9.43 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 9.43 MB

compressed-size-action

@EDsCODE EDsCODE merged commit b1e06a4 into master Jan 3, 2025
99 checks passed
@EDsCODE EDsCODE deleted the modeling-update-run-at-after-completion branch January 3, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gilbert09 Gilbert09 Gilbert09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EDsCODE @Gilbert09