Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix 404s in main README.md #27206

Merged

Conversation

ayyjohn
Copy link
Contributor

@ayyjohn ayyjohn commented Dec 31, 2024

Problem

some links in the product analytics section are 404ing

Changes

image a number of the links in the above photo have been updated.

one note: I did my best to find what the likely replacement link should be, but there's a chance that others were intended because there isn't a 1:1 mapping of old docs -> new docs.

A lot of them seemed to just be due to product-analytics getting its own nested docs page.
It's also possible that some of these shouldn't be fixed manually but should be fixed with an automatic redirect, like how https://posthog.com/docs/data/persons is redirected from https://posthog.com/manual/persons

Does this work well for both Cloud and self-hosted?

it doesn't have an impact

How did you test this code?

pushed the code to my personal fork, clicked the links in the readme to check that they work now

@Twixes Twixes requested a review from joethreepwood January 2, 2025 11:35
@joethreepwood joethreepwood requested review from andyvan-ph and removed request for joethreepwood January 2, 2025 11:47
@joethreepwood
Copy link
Contributor

Thanks, @ayyjohn -- I'm tagging @andyvan-ph to review these as the head of the Docs team. Looks good to me, but he'll have the best read on whether these point to the right place.

@andyvan-ph andyvan-ph merged commit c916c96 into PostHog:master Jan 2, 2025
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants