Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contrast for LemonButton type=primary status=danger #27194

Merged
merged 7 commits into from
Jan 6, 2025
Merged
Binary file modified frontend/__snapshots__/lemon-ui-lemon-button--loading--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/lemon-ui-lemon-dialog--customised--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions frontend/src/lib/lemon-ui/LemonButton/LemonButton.scss
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,16 @@
--lemon-button-icon-opacity: 1;
}

&.LemonButton--primary.LemonButton--status-danger {
--lemon-button-bg-color: var(--red-100);
--lemon-button-color: var(--text-3000);

[theme='dark'] & {
--lemon-button-bg-color: #312101;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels weird to use a one-off color here, although I haven't given it thought how to fit it into the system

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the one off being out of place, but it's changing soon

--lemon-button-color: var(--red-200);
}
}

&.LemonButton--secondary.LemonButton--status-alt {
--lemon-button-color: var(--muted);

Expand Down
Loading