Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(periodic-digest): add periodic digest notification setting #27191

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

raquelmsmith
Copy link
Member

@raquelmsmith raquelmsmith commented Dec 30, 2024

Problem

People need to be able to turn these digests off completely and for specific projects.

Changes

  • Added the notification settings to the user.
  • Made a util function to check the user notif settings
    • I don't love how this has to have specific code written for every setting type, but because they could either be true-default or false-default settings (ie does setting the value to true disable or enable it? we could have a mix) this is how we can handle it I guess? Also lets us handle setting overrides, like the global "disable all digests" setting that should override any per-project setting.
  • Added to the user settings page
    Cursor 2024-12-30 13 58 43

I don't love this UI, open to other good ideas.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

All tests still pass, importantly the usage_report ones because I changed the capture_event function location. So hopefully that means this didn't break anything.

@raquelmsmith raquelmsmith requested a review from a team December 30, 2024 22:03
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants