draft: danger button primary dark #27184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamleithp
changed the title
adamleithp
changed the title
📸 UI snapshots have been updated60 snapshot changes in total. 0 added, 60 modified, 0 deleted:
Triggered by this commit. |
adamleithp
force-pushed
the
fix-danger-button-primary-dark
branch
from
f6c4f9c to
9002bfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dark mode primary danger button has broken contrast with a yellow background. Although this is not the recommended way to use the button with these two props (primary + danger) there are some instances in the code where it occurs, and instead of changing those files, let's just fix from here for now.
Changes
Before:
After:
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
Storybook