Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support mappings for server-side CDP destinations #27168

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 27, 2024

Problem

We added the mappings concept for site destinations and now we want them for server side to. This effectively changes a function into a one-to-many invocation pattern.

Changes

  • Modified filtering to generate metrics and logs directly
  • Modified filtering to support mappings (if mappings is undefined then nothing happens
  • Tests to ensure that inputs are generated correctly

Follow up

  • Migrate all existing functions to mappings?
  • Remove non-input globals by default?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

  • Tests!

@benjackwhite benjackwhite requested a review from a team January 2, 2025 15:41
@benjackwhite benjackwhite marked this pull request as ready for review January 2, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant