Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hedgehog accessories #27165

Merged
merged 3 commits into from
Dec 27, 2024
Merged

fix: Hedgehog accessories #27165

merged 3 commits into from
Dec 27, 2024

Conversation

benjackwhite
Copy link
Contributor

Problem

Accessories are broken
Tailwind classes need to be statically derivable which these weren't.

Changes

  • Fixed them to be style props

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

github-actions bot commented Dec 27, 2024

Size Change: -5 B (0%)

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.11 MB -5 B (0%)

compressed-size-action

@benjackwhite benjackwhite enabled auto-merge (squash) December 27, 2024 10:42
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite merged commit 4797290 into master Dec 27, 2024
99 checks passed
@benjackwhite benjackwhite deleted the fix/hedgehog-hats branch December 27, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants