Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(errors): Store error metadata for sorting #27157

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

neilkakkar
Copy link
Collaborator

Problem

We want to fetch errors from pg for a faster load time. This involves having some estimates for sorting based on count and last seen.

This PR:

  1. Adds these fields to our issue model
  2. Updates cymbal to update these in a redis store
  3. Adds a celery task that runs every 10 mins to update last seen and issue counts in pg (do we need this to be more realtime?)

I opted not to directly write to pg from cymbal because this can easily overwhelm db writes i think, since we'll be writing on every event.

Also didn't try too much (yet) to keep the redis nos consistent, and think we should anyway have a sync to update these estimates to be more accurate nightly. This is probably also needed to help keep accurate counts for merges/splits/issue overrides.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant