chore(experiments): Stats cleanup #27151
Open
+249
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| conversion rate) compared to all other variants, including the control. It uses samples | ||
| drawn from the posterior Beta distributions of each variant's conversion rate. | ||
| conversion rate) compared to all other variants, including the control. It uses Beta | ||
| distributions to model conversion rates, which is the conjugate prior for binomial data. |
There was a problem hiding this comment.
What's a "conjugate prior for binomial data"? In the code comments I'd aim for the same level of simplicity as in our docs :)
There was a problem hiding this comment.
Explained with aeff274
| self.assertEqual(significance, ExperimentSignificanceCode.LOW_WIN_PROBABILITY) | ||
| self.assertEqual(p_value, 1) | ||
|
|
||
| # Check credible intervals | ||
| self.assertAlmostEqual(intervals["control"][0], 0.05, delta=0.05) |
There was a problem hiding this comment.
Uh oh, the tolerated delta here is definitely too wide 👍
| @@ -58,16 +60,16 @@ def run_test(stats_version, calculate_probabilities, are_results_significant, ca | |||
|
|
|||
| self.assertEqual(len(probabilities), 2) | |||
| if stats_version == 2: | |||
| self.assertAlmostEqual(probabilities[0], 0.15, delta=0.1) | |||
| self.assertAlmostEqual(probabilities[1], 0.85, delta=0.1) | |||
| self.assertAlmostEqual(probabilities[0], 0.149, delta=0.1) | |||
There was a problem hiding this comment.
What's the reason for keeping delta=0.1 here? The range seems too wide (0.049 -> 0.249, i.e. 4.9% to 24.9%)
There was a problem hiding this comment.
Not sure, must've skipped over it. Updated with e37b745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26713
Changes
Some cleanup while working on PostHog/posthog.com#10217:
placesinstead ofdeltafor credible intervals.How did you test this code?
Tests should pass.