feat: add insight and remove insight from dashoard #27138
+667
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
…Hog/posthog into feat/add-insight-to-dashboard-modal
thmsobrmlr
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Hey @k11kirky, awesome job getting this started - seriously, this is such a great addition! It's kind of wild we didn’t have this feature already.
A few remarks from my end:
- Pagination in the modal does not work.
- It would be great to have an "in progress" state that disables the individual buttons, while an insight is added or removed.
- I know our UI is quite inconsistent across places, but it would be great if we'd get more consistent eventually (i.e. doesn't need to be addressed here, just wanted to share). In particular it would be nice to be closer to the "Add insight to dashboard" modal visually, e.g.
- A secondary "Add to dashboard" button instead of the primary "+".
- "Close" and "Add new insight" buttons in footer.
- Plain view vs table.
| </> | ||
| } | ||
| > | ||
| {/* <p>Add insight to dashboard {dashboard?.name}</p> */} |
There was a problem hiding this comment.
This file seems to contain a lot of duplication from the saved insights page. Can we dry up the code and at least import all the metadata from there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
You cannot add existing insights to a dashboard from the dashboard screen. This creates a confusing UX and likely duplicate created insights.
Changes
When you click add insight from the dashboard a new modal will pop up allowing you to select an exisitng insight or create a new one.