Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(product-assistant): loop in the schema generation #27111

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(product-assistant): loop in the schema generation #27111

merged 1 commit into from
Dec 20, 2024
+14 −8

Conversation

skoob13
Copy link
Contributor

@skoob13 skoob13 commented Dec 20, 2024 •
edited
Loading

Problem

Pydantic merges None values differently, so plan and intermediate_steps are not reset. It leads to a cycle in subsequent generations.

Changes

  • Replace Nones with falsy values.

Does this work well for both Cloud and self-hosted?

No

How did you test this code?

Manual testing and unit tests.

@skoob13 skoob13 requested a review from Twixes December 20, 2024 16:54
@skoob13 skoob13 marked this pull request as ready for review December 20, 2024 16:54
@skoob13 skoob13 enabled auto-merge (squash) December 20, 2024 17:02
@skoob13 skoob13 merged commit 10d254f into master Dec 20, 2024
97 checks passed
@skoob13 skoob13 deleted the fix/assistant-loop-in-generation branch December 20, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skoob13 @Twixes