fix(experiments): Display no-code experiment secondary metrics #27107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
jurajmajerik
approved these changes
Dec 20, 2024
danielbachhuber
deleted the
experiments/fix-secondary-metrics-web-experiment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://posthoghelp.zendesk.com/agent/tickets/22270
Changes
Ensures secondary metric results are displayed for no-code web experiments.
A no-code web experiment can be created without
experiment.parameters.feature_flag_variants, which will then cause this loop to fail.experiment.feature_flag.filters.multivariate.variantsis a better source of truth.You can ignore the fact that
tabularSecondaryMetricResultsdoesn't actually return any results (just an array of objects). I'm assuming it will be removed once #27014 is applied.How did you test this code?
I verified that secondary metric results started appearing for a no-code web experiment. I also verified that secondary metric results appeared for an existing experiment.