Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experiments): Avoid overriding feature flag payloads #27102

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

danielbachhuber
Copy link
Contributor

See https://posthog.slack.com/archives/C07Q2U4BH4L/p1734548216860989

Changes

Moves DistributionModal update logic to a standalone updateDistributionModal() method where we can wait to run updateExperiment() after the feature flags API call.

This PR reverts #26772, which introduced this problem. The underlying problem is that including parameters in the request will override any existing feature flag information that isn't present in the request.

Hope that this is an even less worse fix.

How did you test this code?

I reproduced the original issue and then verified this approach fixes it.

Original issue

CleanShot.2024-12-20.at.05.06.55.mp4

Fix applied

CleanShot.2024-12-20.at.05.05.20.mp4

@danielbachhuber danielbachhuber requested review from dmarticus and a team December 20, 2024 13:10
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@danielbachhuber danielbachhuber merged commit 02ad064 into master Dec 20, 2024
99 checks passed
@danielbachhuber danielbachhuber deleted the experiments/fix-updating-release-conditions branch December 20, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants