Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no django proxy to rust capture #27099

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: no django proxy to rust capture #27099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9835111
fix: no django proxy to rust capture
pauldambra Dec 20, 2024
1055b95
lazy flyby
pauldambra Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/scenes/settings/environment/ReplayTriggers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,8 @@ function UrlBlocklistOptions(): JSX.Element | null {
return (
<UrlConfigSection
type="blocklist"
title="Block recordings when URL matches"
description="Adding a URL blocklist means recording will be paused when the user visits a page that matches the URL."
title="Pause recordings when URL matches"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot I had this on my machine and can't face waiting for two lots of CI 🫠

description="Recording will be paused when the user visits a page that matches the URL."
isAddFormVisible={isAddUrlBlocklistConfigFormVisible}
config={urlBlocklistConfig}
editIndex={editUrlBlocklistIndex}
Expand Down
2 changes: 0 additions & 2 deletions posthog/settings/web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@
]

if DEBUG:
# Used on local devenv to reverse-proxy all of /i/* to capture-rs on port 3000
INSTALLED_APPS.append("revproxy")
# rebase_migration command
INSTALLED_APPS.append("django_linear_migrations")

Expand Down
5 changes: 1 addition & 4 deletions posthog/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
SpectacularRedocView,
SpectacularSwaggerView,
)
from revproxy.views import ProxyView

from sentry_sdk import last_event_id
from two_factor.urls import urlpatterns as tf_urls

Expand Down Expand Up @@ -248,9 +248,6 @@ def opt_slash_path(route: str, view: Callable, name: Optional[str] = None) -> UR
# what we do.
urlpatterns.append(path("_metrics", ExportToDjangoView))

# Reverse-proxy all of /i/* to capture-rs on port 3000 when running the local devenv
urlpatterns.append(re_path(r"(?P<path>^i/.*)", ProxyView.as_view(upstream="http://localhost:3000")))


if settings.TEST:
# Used in posthog-js e2e tests
Expand Down
4 changes: 0 additions & 4 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,6 @@ googleapis-common-protos==1.60.0
# via
# -c requirements.txt
# opentelemetry-exporter-otlp-proto-grpc
greenlet==3.1.1
# via
# -c requirements.txt
# sqlalchemy
grpcio==1.63.2
# via
# -c requirements.txt
Expand Down
1 change: 0 additions & 1 deletion requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ django-prometheus==2.2.0
django-redis==5.2.0
django-statsd==2.5.2
django-structlog==2.1.3
django-revproxy==0.12.0
djangorestframework==3.15.1
djangorestframework-csv==2.1.1
djangorestframework-dataclasses==1.2.0
Expand Down
4 changes: 0 additions & 4 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ django==4.2.15
# django-phonenumber-field
# django-picklefield
# django-redis
# django-revproxy
# django-structlog
# django-two-factor-auth
# djangorestframework
Expand Down Expand Up @@ -192,8 +191,6 @@ django-prometheus==2.2.0
# via -r requirements.in
django-redis==5.2.0
# via -r requirements.in
django-revproxy==0.12.0
# via -r requirements.in
django-statsd==2.5.2
# via -r requirements.in
django-structlog==2.1.3
Expand Down Expand Up @@ -779,7 +776,6 @@ uritemplate==4.1.1
urllib3==1.26.18
# via
# botocore
# django-revproxy
# geoip2
# google-auth
# pdpyras
Expand Down
Loading