feat(experiments): define custom Trends exposure in the modal #27097
Conversation
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
| { | ||
| kind: NodeKind.EventsNode, | ||
| name: '$pageview', | ||
| event: '$pageview', |
There was a problem hiding this comment.
What's the rationale for using $pageview here?
There was a problem hiding this comment.
Need to set some default event here, and $pageview is our default everywhere. But maybe $feature_flag_called makes more sense.
| trendsFilter: { | ||
| display: ChartDisplayType.ActionsLineGraph, | ||
| }, | ||
| filterTestAccounts: true, |
There was a problem hiding this comment.
Does dateRange and filterTestAccounts need to be hard-coded? It seems like they should be derived from other configuration.
There was a problem hiding this comment.
dateRange should be okay as is - it's suitable for the preview (last 14 days), and it gets updated in the query runner when calculating results.
filterTestAccounts - probably a good idea..
| }, | ||
| { | ||
| key: 'exposure', | ||
| label: 'Exposure', |
There was a problem hiding this comment.
Oops, I didn't realize we accidentally dropped the exposure metric UI for Trends. I'm surprised we haven't gotten any tickets about that.
There was a problem hiding this comment.
Uhm we didn't? https://us.posthog.com/project/2/experiments/73149
There was a problem hiding this comment.
@jurajmajerik You're right. I was looking at a data warehouse trends experiment where we did remove the UI element.
Problem
In the new metrics view, we no longer use the
Goalcomponent (see screenshot) to view and edit the custom exposure metric for Trends.Changes
Add the ability to edit the exposure metric from within the Trends metric modal. This is for primary metrics only. Will repeat this for secondary metrics in a follow up.
How did you test this code?
👀