-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Sidebar - Max #27091
base: master
Are you sure you want to change the base?
feat: Support Sidebar - Max #27091
Conversation
…so added 1 line to URL validation in the system prompt.
flashy/blinky behavior seen while typing after Max had included a codeblock in a response.
a collapsible, "Explore the docs", because less scrolling is more betterer.
…in the sidepanel instead of in a new tab.
… this commit. Will be pairing with others to revive him.
…n be run on the local with this commit, but can't run Max yet, need to know how to handle secrets correctly.
…ation management, improved token and cache tracking.
…PostHog/posthog into support-sidebar-max-integration
…o anthropic API doesn't work in this commit, pushing it to pair with Michael on it.
… removed dead code, included 'title' in things hidden by the feature flag. (still need help from infra with encrypting Max's secrets.)
frontend/src/layout/navigation-3000/sidepanel/panels/sidePanelMaxAILogic.ts
Dismissed
Show dismissed
Hide dismissed
c7a4f5e
to
1983eb8
Compare
/** If true, docs links will not be opened in the docs panel */ | ||
disableDocsPanel?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't disableClientSideRouting
achieve the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of an exception to allow links generated by Max to open in a new tab, since there's code to force links from the Docs
panel to ignore target="_blank
. This is part of the exception carved out for links that Max includes in his answers so they'll open in a new tab (currently we'd lose the chat session if the links opened in the sidepanel instead of a new tab.)
The key difference:
disableDocsPanel
is specific to documentation links and controls whether they open in the side paneldisableClientSideRouting
is a broader setting that affects all navigation, determining whether links should trigger a full page load or use client-side routing
|
||
# Max-specific entries | ||
ee/support_sidebar_max/max-venv/ | ||
ee/support_sidebar_max/.vscode | ||
ee/support_sidebar_max/.vscode/settings.json | ||
max-test-venv/ | ||
ee/support_sidebar_max/.env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of these additions should be needed after we've moved this Max out of Flask and into Django – let's remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some functions were moved, but the main python script is still in use and still in ee/support_sidebar_max
(sidebar_max_AI.py
), so I still don't want to be pushing those items from my local. (I can and will remove max-test-venv
though, done with that.)
package.json
Outdated
@@ -66,6 +66,7 @@ | |||
"mypy-baseline-sync": "mypy -p posthog | mypy-baseline sync" | |||
}, | |||
"dependencies": { | |||
"@anthropic-ai/sdk": "^0.33.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it seems we don't use this anywhere, so let's remove. This means package.json and pnpm-lock.yaml should have no changes in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! The Node.js/JavaScript version of the SDK, while in our Python code we're using the Python SDK. Shall remove.
…PostHog/posthog into support-sidebar-max-integration
Size Change: +68 B (+0.01%) Total Size: 1.11 MB ℹ️ View Unchanged
|
Problem
Support AI Chat for the support sidebar. Help users help themselves, reduce support ticket volume.
Does this work well for both Cloud and self-hosted?
Cloud only
How did you test this code?
Lots of chatting with Max, in two browsers concurrently.
Feature flag in place for a bit more internal testing before we give access to a small set of customers initially.
Edit: Once this review is done, I'll be submitting another PR for this more recent commit