fix: Survey's placeholder customization not showing up #27089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasheriques
changed the title
dmarticus
approved these changes
Dec 19, 2024
| @@ -2,8 +2,7 @@ import './EditSurvey.scss' | |||
|
|
|||
| import { DndContext } from '@dnd-kit/core' | |||
| import { SortableContext, verticalListSortingStrategy } from '@dnd-kit/sortable' | |||
| import { IconInfo } from '@posthog/icons' | |||
| import { IconLock, IconPlus, IconTrash } from '@posthog/icons' | |||
| import { IconInfo, IconLock, IconPlus, IconTrash } from '@posthog/icons' | |||
There was a problem hiding this comment.
did you intend to add IconInfo here? I think this might cause CI to yap because we're not using it afaict.
There was a problem hiding this comment.
i didn't intend to touch this! but I think what happened here is that my editor combined those two lines when formatting. if you see, ItemInfo was always there, and it's used in the file, but before we were importing it in a separate line
Comment on lines
+140
to
+144
| value={ | ||
| appearance?.placeholder !== undefined | ||
| ? appearance.placeholder | ||
| : defaultSurveyAppearance.placeholder | ||
| } |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
lucasheriques
force-pushed
the
fix/survey-placeholder-issue
branch
from
68f5cd6 to
f73cc00
Compare
lucasheriques
force-pushed
the
fix/survey-placeholder-issue
branch
from
f73cc00 to
bed5419
Compare
marandaneto
approved these changes
Dec 20, 2024
|
Noice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes the issue in #26750
Changes
We're only checking the first question to determine wether to show the placeholder option. Instead, check all questions to determine we want to show it.
And also allows an empty string to be set as the placeholder. Before, it always defaults to the default placeholder
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Tested locally in the UI, as it's a bug fix