Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix up batch export addon requirement #27073

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

benjackwhite
Copy link
Contributor

Problem

2 things this PR is trying to solve:

  1. A staff user can't setup our special http export without the pipelines addon which is annoying
  2. We only do frontend checks for the addon which is not good

Changes

  • Adds a new button if impersonating to allow bypassing the UI restrictions
  • Fixed up the http endpoints for batch exports to validate the addon unless impersonated

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

# Conflicts:
#	frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--dark.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants