Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add keyboard shortcut to inside button on search result preview #27071

Merged
merged 9 commits into from
Dec 19, 2024
Merged

fix: add keyboard shortcut to inside button on search result preview #27071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
55a6b91
fixed search bar layout and ux: can now click on search results on de…
adamleithp Dec 18, 2024
04e2cbf
fixed search bar layout for firefox
adamleithp Dec 18, 2024
f6d2a1e
added better comments on px values in search bar
adamleithp Dec 18, 2024
8fc20ac
removed outline on LemonInput--type-search, will address later
adamleithp Dec 19, 2024
e51011f
Merge branch 'master' into adam/search-result-button-updated
adamleithp Dec 19, 2024
a464df1
Merge branch 'master' into adam/search-result-button-updated
adamleithp Dec 19, 2024
31f8588
Update UI snapshots for `chromium` (2)
github-actions[bot] Dec 19, 2024
7086b5b
Update UI snapshots for `chromium` (2)
github-actions[bot] Dec 19, 2024
057dc16
Update UI snapshots for `chromium` (2)
github-actions[bot] Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown-edit--light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 1 addition & 9 deletions frontend/src/lib/components/CommandBar/SearchResultPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,10 @@ export const SearchResultPreview = (): JSX.Element | null => {
onClick={() => {
openResult(activeResultIndex)
}}
tooltip={
<>
Open <KeyboardShortcut enter />
</>
}
aria-label="Open search result"
>
Open
<span className="mr-1">Open</span> <KeyboardShortcut enter />
</LemonButton>
<div>
<KeyboardShortcut enter /> Open
</div>
</div>
</div>
</div>
Expand Down
5 changes: 0 additions & 5 deletions frontend/src/lib/lemon-ui/LemonInput/LemonInput.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,6 @@
// NOTE Design: Search inputs are given a specific small width
max-width: 240px;
border-radius: 0;

// Add a focus ring to the element (not the input) when focused
&:has(:focus-visible) {
outline: -webkit-focus-ring-color auto 1px;
}
}

&.LemonInput--type-number {
Expand Down
Loading