Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use DB choice for hog functions #27069

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

benjackwhite
Copy link
Contributor

Problem

Constant DB migrations feel unnecessary. We can get almost all the benefits without needing migrations

Changes

  • Remove the choice at the field level, and move to the serializer

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite enabled auto-merge (squash) December 20, 2024 12:28
@benjackwhite benjackwhite merged commit 04b8d75 into master Dec 20, 2024
92 checks passed
@benjackwhite benjackwhite deleted the feat/drop-hog-function-type branch December 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants