chore(experiments): clean up legacy experimentResults #27064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-metric-results-cleanup
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
jurajmajerik
commented
Dec 19, 2024
| @@ -96,6 +96,7 @@ describe('Experiments', () => { | |||
| cy.get('[data-attr="experiment-creation-date"]').contains('a few seconds ago').should('be.visible') | |||
| cy.get('[data-attr="experiment-start-date"]').should('not.exist') | |||
|
|
|||
| cy.wait(1000) | |||
There was a problem hiding this comment.
Some re-rendering glitch causes the click to fail. Waiting for a bit solves this; no issues when testing manually.
danielbachhuber
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cleaned up the legacy
experimentResultsvalue and its associated loader, methods and values. All values are now pulled frommetricResults.How did you test this code?
Visually tested with and without the
experiment-multiple-metricsflag.