Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(product-assistant): interruption flag for human-in-the-loop #27057

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

skoob13
Copy link
Contributor

@skoob13 skoob13 commented Dec 19, 2024

Problem

We need a generalized approach with a human in the loop. For the initial implementation, I decided to change state values, but this approach doesn't work if there are interruptions in more than one node. Let's use a flag to mark that the graph has been interrupted so nodes will handle the new state on their own.

Changes

  • Add the flag resumed marking that the node has been resumed after a human in the loop.

Does this work well for both Cloud and self-hosted?

No

How did you test this code?

Unit tests.

@skoob13 skoob13 force-pushed the feat/interrupted-generation-flag branch from 1c9eb35 to 9472727 Compare December 20, 2024 09:48
@skoob13 skoob13 changed the title feat(product-assistant): use a flag for human-in-the-loop feat(product-assistant): interruption flag for human-in-the-loop Dec 20, 2024
@skoob13 skoob13 requested a review from Twixes December 20, 2024 10:03
@skoob13 skoob13 marked this pull request as ready for review December 20, 2024 10:03
@skoob13 skoob13 enabled auto-merge (squash) December 20, 2024 15:06
@skoob13 skoob13 disabled auto-merge December 20, 2024 15:54
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, generally looks like we should be storing more on the nodes. E.g. query results are currently retrieved in the summarizer and not stored in nodes, but now planning to store on nodes so that we can reference data from a couple messages back

@Twixes Twixes merged commit e5a8530 into master Dec 20, 2024
100 checks passed
@Twixes Twixes deleted the feat/interrupted-generation-flag branch December 20, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants