Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(product-assistant): revert speed up evaluation tests (#26926) #27047

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

skoob13
Copy link
Contributor

@skoob13 skoob13 commented Dec 19, 2024

This reverts commit fb3bad7.

Problem

I incorrectly applied a pytest marker, so it skips all tests now.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@skoob13 skoob13 requested a review from Twixes December 19, 2024 11:08
@skoob13 skoob13 changed the title Revert "chore(product-assistant): speed up evaluation tests (#26926)" chore(product-assistant): revert speed up evaluation tests (#26926) Dec 19, 2024
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pauldambra pauldambra merged commit 4e0ef30 into master Dec 19, 2024
89 of 93 checks passed
@pauldambra pauldambra deleted the revert-26926 branch December 19, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants