feat(experiments): detailed results for primary metrics #27046
Conversation
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
|
😱
|
…osthog into primary-metrics-detail
…ary-metrics-detail
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
…osthog into primary-metrics-detail
cypress/e2e/experiments.cy.ts
Outdated
| @@ -96,6 +96,7 @@ describe('Experiments', () => { | |||
| cy.get('[data-attr="experiment-creation-date"]').contains('a few seconds ago').should('be.visible') | |||
| cy.get('[data-attr="experiment-start-date"]').should('not.exist') | |||
|
|
|||
| cy.wait(1000) | |||
There was a problem hiding this comment.
Some re-rendering glitch causes the click to fail. Waiting for a bit solves this; no issues when testing manually.
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Nice! Starting to look like something! Great to be able to quickly click into a metric and see the timeline of it 👍 Maybe add a button to explore the metric further in the product analytics tool?
Not for later: Something we can easily support here as well is pre-exposure / post-exposure analysis (by allowing the user to change the date filter). We got this feature request a lot in my previous gig. And it makes sense, as it allows users to see if there was any bias in the groups prior to the experiment.
Unrelated to this change maybe: It looks a bit weird in fullscreen, maybe limit the width of the metrics component?
Good catch, will add in a follow up 👍
Will make the responsiveness better in a follow up too
I'll create an issue for this! |
Problem
Part of #27014
Changes
Feature flag:
experiments-multiple-metricsHow did you test this code?
👀