Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved our theme switching from custom attribute theme= to class based. #27045

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

adamleithp
Copy link
Contributor

@adamleithp adamleithp commented Dec 19, 2024

Problem (not really)

Changes

TBD

Does this work well for both Cloud and self-hosted?

TBD

How did you test this code?

TDB

@adamleithp adamleithp marked this pull request as draft December 19, 2024 10:53
@posthog-bot
Copy link
Contributor

Hey @adamleithp! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@adamleithp adamleithp force-pushed the adam/darkmode-to-class branch from d9e34bd to 10f0212 Compare December 19, 2024 11:09
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1002 snapshot changes in total. 0 added, 1002 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Size Change: +25 B (0%)

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.11 MB +25 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

486 snapshot changes in total. 0 added, 486 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants