Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Importing inputs from other inputs #27041

Merged
merged 5 commits into from
Dec 20, 2024
Merged

fix: Importing inputs from other inputs #27041

merged 5 commits into from
Dec 20, 2024
+305 −41

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 19, 2024 •
edited by mariusandra
Loading

Problem

Inputs can't depend on other inputs

Changes

Now they can! Circular dependencies are reported as errors:

2024-12-19 17 02 45

How did you test this code?

Updated a bunch of tests, clicked around in the UI, saw inputs inlined in the test invocation.

@mariusandra mariusandra marked this pull request as ready for review December 19, 2024 16:05
mariusandra
mariusandra approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve... though will wait for tests, more eyes, etc before merging.

@mariusandra mariusandra enabled auto-merge (squash) December 20, 2024 09:44
@mariusandra mariusandra merged commit 198678d into master Dec 20, 2024
92 checks passed
@mariusandra mariusandra deleted the fix/nested-inputs branch December 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @mariusandra