chore: Bump luxon types #27030
Merged
chore: Bump luxon types #27030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
commented
Dec 18, 2024
| return { ...(person as BasePerson), ...(person.created_at ? { created_at: person.created_at.toISO() } : {}) } | ||
| return { | ||
| ...(person as BasePerson), | ||
| ...(person.created_at ? { created_at: person.created_at.toISO() ?? undefined } : {}), |
There was a problem hiding this comment.
toISO could have been returning null, and we were expecting string | undefined
There was a problem hiding this comment.
Watch this be a subtly very important bug that the whole codebase relied on 😆
benjackwhite
approved these changes
Dec 19, 2024
| return { ...(person as BasePerson), ...(person.created_at ? { created_at: person.created_at.toISO() } : {}) } | ||
| return { | ||
| ...(person as BasePerson), | ||
| ...(person.created_at ? { created_at: person.created_at.toISO() ?? undefined } : {}), |
There was a problem hiding this comment.
Watch this be a subtly very important bug that the whole codebase relied on 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're using a version of @types/luxon which doesn't match our version of luxon.
I want to use other luxon functions in a different PR, and the types have changed. That other PR is big, so I just pulled this out its own PR
Changes
Bump the types
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tests still pass